![]() Wikipedia for Android makes extensive use of WebViews. Please ask us first before undertaking such a task. Adopt shiny new library X throughout the app: Similarly, adopting a new library (especially one that impacts our code in a fundamental way) is a decision that we make internally as a team.Huge fundamental changes to our code are done gradually, and are decided by us internally as a team. Complete overhauls of our code: A pull request that converts our entire code base to Kotlin might be very impressive in its size, but it's completely unusable to us because of the amount of reviewing, testing, and adjusting that we would need to do to accept it.Please avoid making these types of contributions: Testable: Whenever possible, include a unit test or two in your pull request.Be very clear about what your pull request does, and make sure the code is clean and readable. Small and concise: Your pull request should fix a single specific issue, or implement a single specific feature. ![]() ![]() Ideally, pull requests from volunteers should be:
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |